fix(receiver/sshcheckreceiver): apply the configured timeout - #50912
Open
ogulcanaydogan wants to merge 1 commit into
Open
fix(receiver/sshcheckreceiver): apply the configured timeout#50912ogulcanaydogan wants to merge 1 commit into
ogulcanaydogan wants to merge 1 commit into
Conversation
ToClient built the ssh.ClientConfig without setting Timeout, so the configured timeout never reached the underlying SSH connection: an unresponsive endpoint could hang the dial indefinitely regardless of the configured value. Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ToClientbuilt thessh.ClientConfigwithout settingTimeout, so the configured timeout never reached the underlying SSH connection. As a result, an unresponsive endpoint could cause the dial to hang indefinitely regardless of the configured value.This change propagates the configured timeout to
ssh.ClientConfig.Timeout.Link to tracking issue
N/A - found while reviewing the code; there is no tracking issue.
Testing
Added an assertion to the existing
TestAllSSHClientSettingstest verifying thatclient.Timeoutmatches the configured value.Without the fix, 5 of 6 subtests fail with the configured timeout expected (for example,
5s) but the actual value remaining0s.Documentation
N/A
Authorship